From a5a6cc4e5fece3f6bb52f59aa31f553ea1b65225 Mon Sep 17 00:00:00 2001 From: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed, 27 May 2020 13:48:15 -0600 Subject: [PATCH] clang-tidy readability-redundant-member-init on gui. --- gui/filterdata.h | 8 ++++---- gui/filterwidgets.h | 12 ++++++------ gui/gpx.h | 10 +++++----- gui/setting.h | 10 +++++----- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/gui/filterdata.h b/gui/filterdata.h index 21310c8f9..954b3f2d5 100644 --- a/gui/filterdata.h +++ b/gui/filterdata.h @@ -59,7 +59,7 @@ public: class TrackFilterData: public FilterData { public: - TrackFilterData(): FilterData(), title(false), titleString(QString()), + TrackFilterData(): title(false), titleString(QString()), move(false), weeks(0), days(0), hours(0), mins(0), secs(0), TZ(false), start(false), @@ -136,7 +136,7 @@ public: class WayPtsFilterData: public FilterData { public: - WayPtsFilterData(): FilterData(), + WayPtsFilterData(): duplicates(false), shortNames(true), locations(false), position(false), radius(false), positionVal(0.0), radiusVal(0.0), @@ -175,7 +175,7 @@ public: class RtTrkFilterData: public FilterData { public: - RtTrkFilterData(): FilterData(), + RtTrkFilterData(): simplify_(false), reverse_(false), limitTo_(100) @@ -200,7 +200,7 @@ public: class MiscFltFilterData: public FilterData { public: - MiscFltFilterData(): FilterData(), + MiscFltFilterData(): nukeRoutes_(false), nukeTracks_(false), nukeWaypoints_(false), diff --git a/gui/filterwidgets.h b/gui/filterwidgets.h index 15ee0f8f7..13e414115 100644 --- a/gui/filterwidgets.h +++ b/gui/filterwidgets.h @@ -103,7 +103,7 @@ public: class BoolFilterOption: public FilterOption { public: - BoolFilterOption(bool& b, QAbstractButton* ck): FilterOption(), b(b), checkBox(ck) + BoolFilterOption(bool& b, QAbstractButton* ck): b(b), checkBox(ck) { } void setWidgetValue() @@ -124,7 +124,7 @@ private: class IntSpinFilterOption: public FilterOption { public: - IntSpinFilterOption(int& val, QSpinBox* sb, int bottom = -100, int top = 100): FilterOption(), val(val), spinBox(sb) + IntSpinFilterOption(int& val, QSpinBox* sb, int bottom = -100, int top = 100): val(val), spinBox(sb) { sb->setRange(bottom, top); } @@ -146,7 +146,7 @@ private: class StringFilterOption: public FilterOption { public: - StringFilterOption(QString& val, QLineEdit* le): FilterOption(), val(val), lineEdit(le) + StringFilterOption(QString& val, QLineEdit* le): val(val), lineEdit(le) { } void setWidgetValue() @@ -172,7 +172,7 @@ public: double maxVal = 1.0E308, int decimals = -1, char format = 'g' - ): FilterOption(), val(val), lineEdit(le), minVal(minVal), + ): val(val), lineEdit(le), minVal(minVal), maxVal(maxVal), decimals(decimals), format(format) { le->setValidator(new QDoubleValidator(minVal, maxVal, decimals, le)); @@ -200,7 +200,7 @@ private: class DateTimeFilterOption: public FilterOption { public: - DateTimeFilterOption(QDateTime& val, QDateTimeEdit* w): FilterOption(), val(val), w(w) + DateTimeFilterOption(QDateTime& val, QDateTimeEdit* w): val(val), w(w) { } void setWidgetValue() @@ -221,7 +221,7 @@ private: class ComboFilterOption: public FilterOption { public: - ComboFilterOption(int& val, QComboBox* w): FilterOption(), val(val), w(w) + ComboFilterOption(int& val, QComboBox* w): val(val), w(w) { } void setWidgetValue() diff --git a/gui/gpx.h b/gui/gpx.h index 2bd140765..85b682384 100644 --- a/gui/gpx.h +++ b/gui/gpx.h @@ -52,7 +52,7 @@ protected: class GpxRoutePoint: public GpxItem { public: - GpxRoutePoint(): GpxItem(), location(LatLng()), name(QString()) + GpxRoutePoint(): location(LatLng()), name(QString()) { } @@ -85,7 +85,7 @@ private: class GpxRoute: public GpxItem { public: - GpxRoute(): GpxItem(),name(QString()), cachedLength(-1) {} + GpxRoute(): name(QString()), cachedLength(-1) {} GpxRoute(const GpxRoute& c) :GpxItem(c.visible), @@ -165,7 +165,7 @@ private: class GpxTrackPoint: public GpxItem { public: - GpxTrackPoint(): GpxItem(), location(LatLng()), elevation(0), dateTime(QDateTime()) + GpxTrackPoint(): location(LatLng()), elevation(0), dateTime(QDateTime()) { } @@ -248,7 +248,7 @@ private: class GpxTrack: public GpxItem { public: - GpxTrack(): GpxItem(), number(1), name(QString()), comment(QString()), description(QString()), cachedLength(-1.0) {} + GpxTrack(): number(1), name(QString()), comment(QString()), description(QString()), cachedLength(-1.0) {} GpxTrack(const GpxTrack& c) :GpxItem(c.visible), @@ -370,7 +370,7 @@ private: class GpxWaypoint: public GpxItem { public: - GpxWaypoint(): GpxItem(), + GpxWaypoint(): location_(LatLng(0, 0)), elevation_(-1.0E-100), name_(QString()), diff --git a/gui/setting.h b/gui/setting.h index 0f111c991..9a770450e 100644 --- a/gui/setting.h +++ b/gui/setting.h @@ -43,7 +43,7 @@ public: class IntSetting: public VarSetting { public: - IntSetting(const QString& name, int& var): VarSetting(), name_(name), var_(var) { } + IntSetting(const QString& name, int& var): name_(name), var_(var) { } void saveSetting(QSettings& st) { st.setValue(name_, var_); @@ -64,7 +64,7 @@ private: class DoubleSetting: public VarSetting { public: - DoubleSetting(const QString& name, double& var): VarSetting(), name_(name), var_(var) { } + DoubleSetting(const QString& name, double& var): name_(name), var_(var) { } void saveSetting(QSettings& st) { st.setValue(name_, var_); @@ -85,7 +85,7 @@ private: class StringSetting: public VarSetting { public: - StringSetting(const QString& name, QString& var): VarSetting(), name_(name), var_(var) { } + StringSetting(const QString& name, QString& var): name_(name), var_(var) { } void saveSetting(QSettings& st) { st.setValue(name_, var_); @@ -106,7 +106,7 @@ private: class BoolSetting: public VarSetting { public: - BoolSetting(const QString& name, bool& var): VarSetting(), name_(name), var_(var) { } + BoolSetting(const QString& name, bool& var): name_(name), var_(var) { } void saveSetting(QSettings& st) { st.setValue(name_, var_); @@ -127,7 +127,7 @@ private: class DateTimeSetting: public VarSetting { public: - DateTimeSetting(const QString& name, QDateTime& var):VarSetting(), name_(name), var_(var) { } + DateTimeSetting(const QString& name, QDateTime& var): name_(name), var_(var) { } void saveSetting(QSettings& st) { st.setValue(name_, var_); -- 2.30.2